Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Support RemoteAttribute, including its client-side validation #439

Closed
NTaylorMullen opened this issue May 10, 2014 · 1 comment
Closed

Comments

@NTaylorMullen
Copy link
Member

One we have UrlAttribute working end-to-end. But MVC-specific validation attributes do not yet exist. And the infrastructure for their client-side validation (IClientValidator) is also not yet in place.

Note we have no other non-obsolete attributes inheriting from IClientValidator. This may be an opportunity to decide whether to carry forward that particular extensibility point. IClientValidator is easy to use but forces a single class to mix validation with a client-side adaptor.

@danroth27 danroth27 added this to the Post Alpha milestone May 13, 2014
@yishaigalatzer yishaigalatzer removed this from the Post Alpha milestone May 23, 2014
@dougbu dougbu added the feature label May 30, 2014
@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Oct 15, 2014
@danroth27 danroth27 modified the milestones: 6.0.0-rc1, 6.0.0-beta2 Oct 20, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0-rc1, 6.0.0-beta2 Dec 12, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0-rc1, 6.0.0-beta3 Jan 14, 2015
dougbu added a commit that referenced this issue Jan 29, 2015
dougbu added a commit that referenced this issue Jan 29, 2015
- #439 (2 of 3)
- correct namespaces
- correct `Resources` class and member names; add new resources
- add `MvcClientModelValidationContext`, giving `[Remote]` an `IUrlHelper` instance
- adjust to modern `IUrlHelper` API
- add `IClientModelValidator` support in `DataAnnotationsModelValidator`
- move previously-unused `StringSplit()` to `StringHelper`
- rewrite `RemoteAttributeTest`
 - improve test method names

Reduce number of `[Remote]` constructor overloads
- remove `AreaReference` enum and related `[Remote]` constructor overload
- use `null` or empty `string` as explicit reference to the root area

Cleanup
- correct Engineering Guidelines violations
 - especially: add doc comments
- correct spelling error in `_additonalFieldsSplit`

nits:
- minimize `null` checks in `AdditionalFields`
- make `GetClientValidationRules` `virtual`; some subclasses use `new` today
dougbu added a commit that referenced this issue Jan 29, 2015
- #439 (3 of 3)
- extended the Validation web site to include use of `[Remote]`
- also confirm operation of the validation actions (which all reject their input)
dougbu added a commit that referenced this issue Jan 30, 2015
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (2 of 3)
- correct namespaces
- correct `Resources` class and member names; add new resources
- add `MvcClientModelValidationContext`, giving `[Remote]` an `IUrlHelper` instance
- adjust to modern `IUrlHelper` API
- add `IClientModelValidator` support in `DataAnnotationsModelValidator`
- move previously-unused `StringSplit()` to `StringHelper`
- rewrite `RemoteAttributeTest`
 - improve test method names

Reduce number of `[Remote]` constructor overloads
- remove `AreaReference` enum and related `[Remote]` constructor overload
- use `null` or empty `string` as explicit reference to the root area

Cleanup
- correct Engineering Guidelines violations
 - especially: add doc comments
- correct spelling error in `_additonalFieldsSplit`

nits:
- minimize `null` checks in `AdditionalFields`
- make `GetClientValidationRules` `virtual`; some subclasses use `new` today
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (3 of 3)
- extended the Validation web site to include use of `[Remote]`
- also confirm operation of the validation actions (which all reject their input)
dougbu added a commit that referenced this issue Jan 30, 2015
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (2 of 3)
- correct namespaces
- correct `Resources` class and member names; add new resources
- add `MvcClientModelValidationContext`, giving `[Remote]` an `IUrlHelper` instance
- adjust to modern `IUrlHelper` API
- add `IClientModelValidator` support in `DataAnnotationsModelValidator`
- move previously-unused `StringSplit()` to `StringHelper`
- rewrite `RemoteAttributeTest`
 - improve test method names

Reduce number of `[Remote]` constructor overloads
- remove `AreaReference` enum and related `[Remote]` constructor overload
- use `null` or empty `string` as explicit reference to the root area

Cleanup
- correct Engineering Guidelines violations
 - especially: add doc comments
- correct spelling error in `_additonalFieldsSplit`

nits:
- minimize `null` checks in `AdditionalFields`
- make `GetClientValidationRules` `virtual`; some subclasses use `new` today
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (3 of 3)
- extended the Validation web site to include use of `[Remote]`
- also confirm operation of the validation actions (which all reject their input)
dougbu added a commit that referenced this issue Jan 30, 2015
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (2 of 3)
- correct namespaces
- correct `Resources` class and member names; add new resources
- add `RequestServices` property to `ClientModelValidationContext`
- adjust to modern `IUrlHelper` API
- add `IClientModelValidator` support in `DataAnnotationsModelValidator`
- move previously-unused `StringSplit()` to `RemoteAttribute` and rename
- rewrite `RemoteAttributeTest`
 - improve test method names

Reduce number of `[Remote]` constructor overloads
- remove `AreaReference` enum and related `[Remote]` constructor overload
 - use `null` or empty `string` as explicit reference to the root area
- generally reduce parameter validation; match `UrlHelper`

Cleanup
- correct Engineering Guidelines violations
 - especially: add doc comments
- correct spelling error in `_additonalFieldsSplit`

nits:
- minimize `null` checks in `AdditionalFields`
- make `GetClientValidationRules` `virtual`; some subclasses use `new` today
- add tests of `DataAnnotationsModelValidator.GetClientValidationRules()`
- remove `builder.ToString()` calls since it appears
  https://roslyn.codeplex.com/workitem/246 has been resolved or Moq has
  worked around that issue.
dougbu added a commit that referenced this issue Jan 30, 2015
- #439 (3 of 3)
- extended the Validation web site to include use of `[Remote]`
- also confirm operation of the validation actions (which all reject their input)
@dougbu
Copy link
Member

dougbu commented Jan 30, 2015

fixed in commits 1af1583 to 6cc5cfe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants