This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Consider unifying the list of assemblies included in the razor compilation with the of assembly parts of the application. #4498
Comments
Sounds quite intriguing. @javiercn can you chat with @rynowak @NTaylorMullen @pranavkm briefly to think this through? |
Cool. |
We had a quick discussion about this offline. We'll introduce a new application feature to represent compilation assets and populate it at the same time the application manager is created. |
/cc @davidfowl - I think you were interested in this |
I had a chat with @davidfowl offline and his suggestion was to not create a separate list for this - just reuse the assembly part we already have. b3618f4 was a design based on that change. |
pranavkm
added a commit
that referenced
this issue
May 18, 2016
pranavkm
added a commit
that referenced
this issue
May 18, 2016
This was referenced May 18, 2016
This would be really great feature! |
pranavkm
added a commit
that referenced
this issue
May 19, 2016
pranavkm
added a commit
that referenced
this issue
May 20, 2016
pranavkm
added a commit
that referenced
this issue
May 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now application part manager is used for controller discovery, view component discovery and tag helper discovery (when doing AddTagHelpersAsServices()). However the assemblies included in the razor compilation are hard to configure. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Razor/RazorViewEngineOptions.cs#L20
We could use application parts in order to define the list of assemblies to include as part of the compilation, this makes it easier to configure the list of assemblies that are part of the compilation (by just adding them to the list of application parts and having a feature that discovers them) and provides a single source of truth for configuring what assemblies are part of the application.
The text was updated successfully, but these errors were encountered: