Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Support TagHelpers as Services ontop of new Razor #5768

Closed
NTaylorMullen opened this issue Feb 8, 2017 · 4 comments
Closed

Support TagHelpers as Services ontop of new Razor #5768

NTaylorMullen opened this issue Feb 8, 2017 · 4 comments
Assignees
@rynowak
Labels
3 - Done bug
Milestone
2.0.0-preview2

Comments

@NTaylorMullen
Copy link
Member

After the conversion to new Razor (Razor.Evolution) we didn't do the work to convert the TagHelpers as services infrastructure.
@NTaylorMullen
Copy link
Member Author

Oh and we currently have a falsely passing test: Microsoft.AspNetCore.Mvc.FunctionalTests.TagHelpersFromServicesTest.TagHelpersWithConstructorInjectionAreCreatedAndActivated.

It's only passing because we're not accurately verifying that the TagHelper is coming from services.

dougbu pushed a commit that referenced this issue Mar 1, 2017
@NTaylorMullen @dougbu
Migrate to MSBuild
acfad83 
- thanx to @NTaylorMullen for initial conversion
  - e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files

Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
  - see 63507c8 for previous, project.json work
- apply dependency version downgrade from 0097e40 in *.csproj world

Make other test-related changes:
- make Microsoft.AspNetCore.Mvc.TestDiagnosticListener a regular class library
- add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests
- separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test
  - work around inability to deserialize a odd `ref` type
  - xUnit and vstest now serialize / deserialze test data more often
- skip poor test mentioned in #5768
- work around microsoft/vstest#392
  - rename tests to avoid duplicates
- work around microsoft/vstest#419
  - set up created `AppDomain`s with current `ApplicationBase`
@ryanbrandenburg
Copy link
Contributor

Some tests and functionality for this was removed as part of #5977 and should be re-added as part of this work.

@NTaylorMullen
Copy link
Member Author

@rynowak / @Eilon this guy should definitely be triaged. It's not great that it isn't making it into preview1

@rynowak rynowak added this to the 2.0.0-preview2 milestone May 3, 2017
@rynowak rynowak self-assigned this May 23, 2017
@rynowak
Copy link
Member

rynowak commented May 23, 2017

a6d97d3

@rynowak rynowak closed this as completed May 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
3 participants
@rynowak @NTaylorMullen @ryanbrandenburg