This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
[Display(Order={i})] ignored when sorting validation summary messages and properties in @Html.Display() / @Html.Editor() object templates
#964
Comments
|
In addition |
dougbu
changed the title
ModelMetadata.Order based on attributes[Display(Order={i})] ignored when sorting validation summary messages and properties in @Html.Display() / @Html.Editor() object templates
|
Main fix here is to set MVC 5.2 does not provide a predictable property order when displaying / editing a complex object or filling in the |
dougbu
added a commit
that referenced
this issue
Aug 14, 2014
- supports useful property updates of `ModelMetadata` instances in the collection - provide a controllable ordering using the `Order` value - part of #964
This was referenced Aug 14, 2014
dougbu
added a commit
that referenced
this issue
Aug 15, 2014
- supports useful property updates of `ModelMetadata` instances in the collection - provide a controllable ordering using the `Order` value - part of #964
dougbu
added a commit
that referenced
this issue
Aug 15, 2014
- supports useful property updates of `ModelMetadata` instances in the collection - provide a controllable ordering using the `Order` value - part of #964
dougbu
added a commit
that referenced
this issue
Aug 15, 2014
- supports useful property updates of `ModelMetadata` instances in the collection - provide a controllable ordering using the `Order` value - part of #964
This was referenced Jan 22, 2015
dougbu
added a commit
that referenced
this issue
Jan 27, 2015
…perty order #964 - compute `ModelMetadata.Order` based on `[Display]` attribute - property affects e.g. `@Html.DisplayFor()` generation for complex objects - also affects order of messages in validation summary - use `PropertyName` to make overall order predictable - update existing tests to match new property order - test new scenarios involving `ModelMetadata.Order` - per-property `ModelMetadata` and related tests - validation and `HtmlHelper` tests - add `HtmlHelperValidationSummaryTest` (which touches on #453) - update ModelBinding functional test to show use of `[Display(Order = x)]` nits: - remove some trailing whitespace - move more `NullDisplayText` bits into proper slots (just above `Order`) - avoid `Assert.True()` & `Assert.False()`; split some assertions up - add more assertions in tests involving `ModelStateDictionary.CanAddErrors` - `""` -> `string.Empty` in affected test classes - rename "DefaultEditorTemplatesTest~~s~~" class and file to follow guidelines - rename "ModelBindingTest~~s~~" class and file to follow guidelines
dougbu
added a commit
that referenced
this issue
Jan 29, 2015
…perty order #964 - compute `ModelMetadata.Order` based on `[Display]` attribute - property affects e.g. `@Html.DisplayFor()` generation for complex objects - also affects order of messages in validation summary - use `PropertyName` to make overall order predictable - update existing tests to match new property order - test new scenarios involving `ModelMetadata.Order` - per-property `ModelMetadata` and related tests - validation and `HtmlHelper` tests - add `HtmlHelperValidationSummaryTest` (which touches on #453) - update ModelBinding functional test to show use of `[Display(Order = x)]` nits: - remove some trailing whitespace - move more `NullDisplayText` bits into proper slots (just above `Order`) - avoid `Assert.True()` & `Assert.False()`; split some assertions up - add more assertions in tests involving `ModelStateDictionary.CanAddErrors` - `""` -> `string.Empty` in affected test classes - rename "DefaultEditorTemplatesTest~~s~~" class and file to follow guidelines - rename "ModelBindingTest~~s~~" class and file to follow guidelines
dougbu
added a commit
that referenced
this issue
Jan 29, 2015
- #964 - compute `ModelMetadata.Order` based on `[Display]` attribute - property affects e.g. `@Html.DisplayFor()` generation for complex objects - also affects order of messages in validation summaries - test new scenarios involving `ModelMetadata.Order` - per-property `ModelMetadata` and related tests - validation and `HtmlHelper` tests - add `HtmlHelperValidationSummaryTest` (which touches on #453) - update ModelBinding functional test to show use of `[Display(Order = x)]` nits: - move more `NullDisplayText` bits into proper slots (just above `Order`) - add doc comments for `ComputeNullDisplayText()` - add more assertions in tests using `ModelStateDictionary.HasReachedMaxErrors` - remove some trailing whitespace - avoid `Assert.True()` & `Assert.False()`; split some assertions up - `""` -> `string.Empty` in affected test classes - rename "DefaultEditorTemplatesTest~~s~~" class and file to follow guidelines - rename "ModelBindingTest~~s~~" class and file to follow guidelines FYI #1888 covers a predictable (or even just stable) order in the UI
|
fixed in commit 8779caf |
|
Using the attribute [Display(Order=x)] only allows developers to fix this proplem if the summary is showing errors for a single entity. This does not fix the problem for other scenarious such as when you wish to display errors for a collection of entities. The problem is simply fixed in this respect by displaying the errors in which they were added to the ModelErrorCollection which it currently does not! Your cracking a nut with a hammer - seemingly? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a regression compared with MVC 5.2 and it's similar to #843, #844, #933, and #963. In this case however it's less than a functional gap; all the expected information is available. The visible symptoms are unpredictable ordering of validation errors and the
Propertiescollection.The current implementation of
CachedModelMetadata<TPrototypeCache>does not override theOrderproperty as it should. Value should be based on[Display]attributes in the model.The text was updated successfully, but these errors were encountered: