Add ValidationSummaryTagHelper. #1340

NTaylorMullen · 2014-10-12T21:46:16Z

dougbu · 2014-10-13T21:56:08Z

src/Microsoft.AspNet.Mvc.TagHelpers/ValidationSummaryTagHelper.cs

+    [ContentBehavior(ContentBehavior.Append)]
+    public class ValidationSummaryTagHelper : TagHelper
+    {
+        private static readonly bool DefaultModelErrorsOnlyBehavior = false;


rename w/o "Behavior"

dougbu · 2014-10-13T22:09:41Z

⌚

NTaylorMullen · 2014-10-14T05:38:40Z

Addressed code review comments to the exception of the one comment with differing opinions 😄

dougbu · 2014-10-16T01:30:14Z

test/Microsoft.AspNet.Mvc.TagHelpers.Test/ValidationSummaryTagHelperTest.cs

+            Assert.Equal("div", output.TagName);
+            Assert.Empty(output.Attributes);
+
+            if (!validationSummary.Equals("None", StringComparison.OrdinalIgnoreCase))


split into two tests rather than conditionalizing the Asserts

dougbu · 2014-10-16T01:32:55Z

⌚

NTaylorMullen · 2014-10-16T03:10:16Z

Addressed code review comments.

NTaylorMullen · 2014-10-16T18:19:00Z

Update TagHelper sample to use new validation-summary format.

dougbu · 2014-10-16T22:34:58Z

src/Microsoft.AspNet.Mvc.TagHelpers/ValidationSummaryTagHelper.cs

+
+        // TODO: Change to ValidationSummary enum once https://github.com/aspnet/Razor/issues/196 has been completed.
+        /// <summary>
+        /// Acceptable values are defined by the <see cref="ValidationSummary"/> enum.


good second sentence in this <summary/>. restore first sentence from an earlier iteration to describe that this property is for.

dougbu · 2014-10-16T22:44:50Z

⌚ just for a quick look at doc comments in next iteration

pranavkm · 2014-10-16T22:59:50Z

src/Microsoft.AspNet.Mvc.TagHelpers/ValidationSummaryTagHelper.cs

+                        Resources.FormatValidationSummaryTagHelper_InvalidValidationSummaryValue(
+                            "validation-summary",
+                            ValidationSummaryValue,
+                            ValidationSummary.All.ToString(),


Shouldn't have to do ToString(), the string.Format would do that for you.

pranavkm · 2014-10-16T23:32:10Z

once @dougbu's happy

NTaylorMullen · 2014-10-16T23:36:55Z

Updated.

dougbu · 2014-10-17T00:13:40Z

src/Microsoft.AspNet.Mvc.TagHelpers/Resources.resx

@@ -126,4 +126,7 @@
  <data name="FormTagHelper_CannotDetermineAction" xml:space="preserve">
    <value>Cannot determine an {1} for {0}. A {0} with a URL-based {1} must not have attributes starting with {3} or a {2} attribute.</value>
  </data>
+  <data name="ValidationSummaryTagHelper_InvalidValidationSummaryValue" xml:space="preserve">
+    <value>Cannot parse {0} value '{1}'. Acceptable values are '{2}', '{3}' and '{4}'.</value>


nit: passing your usual rule back 😸 add "for {2}" just before the first period

quote current {0} as well -> '{0}' (though that should probably become {1} and so on

dougbu · 2014-10-17T00:23:05Z

after addressing my 2 (or so) minor comments

- Tested ValidationSummaryTagHelper behavior. - Updated sample to utilize new ValidationSummaryTagHelper format. #1251

NTaylorMullen · 2014-10-17T00:44:41Z

Done in TagHelpersFeature via ba111a4

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 4473a33 to de8706e Compare October 13, 2014 06:27

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from ff71b0b to a8a3ccb Compare October 13, 2014 06:27

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from de8706e to 108a0ba Compare October 13, 2014 17:53

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from a8a3ccb to 7dd31d5 Compare October 13, 2014 17:53

dougbu reviewed Oct 13, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 108a0ba to af0ac42 Compare October 14, 2014 00:48

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from 7dd31d5 to b3d6569 Compare October 14, 2014 00:48

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from af0ac42 to 0708aef Compare October 14, 2014 05:32

NTaylorMullen changed the title ~~[Design] Add ValidationSummaryTagHelper.~~ Add ValidationSummaryTagHelper. Oct 14, 2014

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch 2 times, most recently from c490007 to c8615e9 Compare October 14, 2014 05:37

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 0708aef to a33aa3e Compare October 14, 2014 05:37

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from a33aa3e to 342362c Compare October 15, 2014 00:30

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from c8615e9 to 6e4dcb6 Compare October 15, 2014 00:30

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 342362c to 8a24434 Compare October 15, 2014 07:02

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from 6e4dcb6 to 65d5145 Compare October 15, 2014 07:03

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 8a24434 to 673a9ea Compare October 15, 2014 18:20

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from 65d5145 to 3a0403c Compare October 15, 2014 18:21

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 673a9ea to 3ff67ca Compare October 15, 2014 23:45

dougbu reviewed Oct 16, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpers_ValidationMessage branch from 1cf6935 to 0d4d7c6 Compare October 16, 2014 19:43

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from de98414 to 99f8720 Compare October 16, 2014 19:43

dougbu reviewed Oct 16, 2014
View reviewed changes

pranavkm reviewed Oct 16, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from 8edcc0c to 3aa9323 Compare October 16, 2014 23:39

dougbu reviewed Oct 17, 2014
View reviewed changes

Add ValidationSummaryTagHelper.

ba111a4

- Tested ValidationSummaryTagHelper behavior. - Updated sample to utilize new ValidationSummaryTagHelper format. #1251

NTaylorMullen force-pushed the TagHelpers_ValidationSummary branch from 3aa9323 to ba111a4 Compare October 17, 2014 00:43

NTaylorMullen closed this Oct 17, 2014

NTaylorMullen deleted the TagHelpers_ValidationSummary branch October 17, 2014 05:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ValidationSummaryTagHelper. #1340

Add ValidationSummaryTagHelper. #1340

NTaylorMullen commented Oct 12, 2014

dougbu Oct 13, 2014

dougbu commented Oct 13, 2014

NTaylorMullen commented Oct 14, 2014

dougbu Oct 16, 2014

dougbu commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

dougbu Oct 16, 2014

dougbu commented Oct 16, 2014

pranavkm Oct 16, 2014

pranavkm commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

dougbu Oct 17, 2014

dougbu Oct 17, 2014

dougbu commented Oct 17, 2014

NTaylorMullen commented Oct 17, 2014

Add ValidationSummaryTagHelper. #1340

Add ValidationSummaryTagHelper. #1340

Conversation

NTaylorMullen commented Oct 12, 2014

dougbu Oct 13, 2014

Choose a reason for hiding this comment

dougbu commented Oct 13, 2014

NTaylorMullen commented Oct 14, 2014

dougbu Oct 16, 2014

Choose a reason for hiding this comment

dougbu commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

dougbu Oct 16, 2014

Choose a reason for hiding this comment

dougbu commented Oct 16, 2014

pranavkm Oct 16, 2014

Choose a reason for hiding this comment

pranavkm commented Oct 16, 2014

NTaylorMullen commented Oct 16, 2014

dougbu Oct 17, 2014

Choose a reason for hiding this comment

dougbu Oct 17, 2014

Choose a reason for hiding this comment

dougbu commented Oct 17, 2014

NTaylorMullen commented Oct 17, 2014