This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Commonize 'throw on view not found' #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduping this code by moving it to ViewEngineResult.
| return; | ||
| } | ||
|
|
||
| var locationsText = Environment.NewLine + string.Join(Environment.NewLine, SearchedLocations); |
There was a problem hiding this comment.
@Tratcher it would be nice if the error page preserved formatting (pre tag). This way we don't need to do anything special for printing these out.
Bonus points if you get it to support markdown
There was a problem hiding this comment.
File a bug in DiagnosticPages.
There was a problem hiding this comment.
AspNet/DiagnosticPages#6 logged by @pranavkm thanks!
|
|
1 similar comment
|
|
|
Addressed comments and merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduping this code by moving it to ViewEngineResult.