This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Rename _GlobalImport.cshtml files to _ViewImports.cshtml #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also rename files and directories with "GlobalImport" in name - nearly blind but avoid "ViewImportss" in new names - public API change: `ViewHierarchyUtility.GetGlobalImportLocations()` -> `GetViewImportsLocations()` - primary source updates were comments, tests, and implementation details nit: - rename NestedGlobalImports.cs file to NestedViewImportsController.cs, matching class
|
Looks |
to me. Add to Announcements repo when you commit.
| @@ -51,7 +51,7 @@ private CodeTree OnCacheMiss(ICacheSetContext cacheSetContext) | |||
| var pagePath = cacheSetContext.Key; | |||
| var getCodeTree = (Func<IFileInfo, CodeTree>)cacheSetContext.State; | |||
|
|
|||
| // GetOrAdd is invoked for each _ViewStart that might potentially exist in the path. | |||
| // GetOrAdd is invoked for each _ViewImports that might potentially exist in the path. | |||
|
|
1 similar comment
|
|
|
FYI was issue #2489 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewHierarchyUtility.GetGlobalImportLocations()->GetViewImportsLocations()nit: