This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
TagHelperElementCompletionService does not filter schema HTML elements based on TagOutputHint #1225
Comments
NTaylorMullen
changed the title
NTaylorMullen
added a commit
that referenced
this issue
Apr 14, 2017
- Prior to this if you had a `TagHelper` whos output hint was not in the final form of the completions we'd fall through into a schema check which resulted in a completion being added when it shouldn't. Example: `TagHelper` for `my-tr` that has an output hint of `tr` would end up getting added to the completion list under `body` because `my-tr` was not in the schema and would then be treated like the `environment` `TagHelper` (a new element). - Added a test to validate that `TagHelper`s with output hints are cross referenced vs. existing completions and do not fall through to a schema check. #1225
NTaylorMullen
added a commit
that referenced
this issue
Apr 14, 2017
- Prior to this if you had a `TagHelper` whos output hint was not in the final form of the completions we'd fall through into a schema check which resulted in a completion being added when it shouldn't. Example: `TagHelper` for `my-tr` that has an output hint of `tr` would end up getting added to the completion list under `body` because `my-tr` was not in the schema and would then be treated like the `environment` `TagHelper` (a new element). - Added a test to validate that `TagHelper`s with output hints are cross referenced vs. existing completions and do not fall through to a schema check. #1225
NTaylorMullen
added a commit
that referenced
this issue
Apr 14, 2017
- Prior to this if you had a `TagHelper` whos output hint was not in the final form of the completions we'd fall through into a schema check which resulted in a completion being added when it shouldn't. Example: `TagHelper` for `my-tr` that has an output hint of `tr` would end up getting added to the completion list under `body` because `my-tr` was not in the schema and would then be treated like the `environment` `TagHelper` (a new element). - Added a test to validate that `TagHelper`s with output hints are cross referenced vs. existing completions and do not fall through to a schema check. #1225
NTaylorMullen
added a commit
that referenced
this issue
Apr 14, 2017
- Prior to this if you had a `TagHelper` whos output hint was not in the final form of the completions we'd fall through into a schema check which resulted in a completion being added when it shouldn't. Example: `TagHelper` for `my-tr` that has an output hint of `tr` would end up getting added to the completion list under `body` because `my-tr` was not in the schema and would then be treated like the `environment` `TagHelper` (a new element). - Added a test to validate that `TagHelper`s with output hints are cross referenced vs. existing completions and do not fall through to a schema check. #1225
NTaylorMullen
added a commit
that referenced
this issue
Apr 14, 2017
- Prior to this if you had a `TagHelper` whos output hint was not in the final form of the completions we'd fall through into a schema check which resulted in a completion being added when it shouldn't. Example: `TagHelper` for `my-tr` that has an output hint of `tr` would end up getting added to the completion list under `body` because `my-tr` was not in the schema and would then be treated like the `environment` `TagHelper` (a new element). - Added a test to validate that `TagHelper`s with output hints are cross referenced vs. existing completions and do not fall through to a schema check. #1225
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: