Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Pool TagHelperExecutionContexts #674

Closed
NTaylorMullen opened this issue Jan 23, 2016 · 3 comments
Closed

Pool TagHelperExecutionContexts #674

NTaylorMullen opened this issue Jan 23, 2016 · 3 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

Today our TagHelperExecutionContexts aren't pooled and end up resulting in ~2.4% of the overall allocations of a page.

image

@Eilon
Copy link
Member

Eilon commented Jan 27, 2016

Moving to Backlog.

@NTaylorMullen
Copy link
Member Author

Doing this real quick. It's a 3% overall perf gain and relatively simple.

@NTaylorMullen NTaylorMullen modified the milestones: 1.0.0-rc2, Backlog Feb 17, 2016
@NTaylorMullen NTaylorMullen self-assigned this Feb 17, 2016
NTaylorMullen added a commit that referenced this issue Feb 18, 2016
- Currently the `TagHelperScopeManager` creates a new `TagHelperExecutionContext` per `TagHelper` on a given page. With this change the max number of `TagHelperExecutionContext`s per page is the number of nested levels that exist.
- Decided to add two tests validating that specific pieces of `TagHelperExecutionContext` are updated as expected.

#674
NTaylorMullen added a commit that referenced this issue Feb 18, 2016
- Currently the `TagHelperScopeManager` creates a new `TagHelperExecutionContext` per `TagHelper` on a given page. With this change the max number of `TagHelperExecutionContext`s per page is the number of nested levels that exist.
- Decided to add two tests validating that specific pieces of `TagHelperExecutionContext` are updated as expected.

#674
NTaylorMullen added a commit that referenced this issue Feb 18, 2016
- Currently the `TagHelperScopeManager` creates a new `TagHelperExecutionContext` per `TagHelper` on a given page. With this change the max number of `TagHelperExecutionContext`s per page is the number of nested levels that exist.
- Decided to add two tests validating that specific pieces of `TagHelperExecutionContext` are updated as expected.

#674
NTaylorMullen added a commit that referenced this issue Feb 19, 2016
- Currently the `TagHelperScopeManager` creates a new `TagHelperExecutionContext` per `TagHelper` on a given page. With this change the max number of `TagHelperExecutionContext`s per page is the number of nested levels that exist.
- Added two tests validating that specific pieces of `TagHelperExecutionContext` are updated as expected.

#674
@NTaylorMullen
Copy link
Member Author

78451ef

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants