String token directives should require quoted values.

[pranavkm]

Quotes are optional for some string-like tokens in directives (for instance in @addTagHelper). However the optionality is enforced at code gen rather than at parse time. We could instead remove quotes from string tokens at parse time.

[rynowak]

We should absolutely not do this. The taghelper directives are special and it is a non goal that they reuse the extensible directives feature.

[pranavkm]

Would we expect to support @page "some-route"? Right now, we end up treating quotes as part of the token. Seems reasonable to generalize this to all "string" like values in descriptors.

[rynowak]

We should only support @page "some-route" and the token api we provide should give you access to the both the 'quoted' span/text and the 'unquoted' span/text.

---

I'll repeat, you can do things with the taghelper directives like:

@addTagHelper Foo, Bar
@addTagHelper "Baz, Bar" 

In both of these cases, everything after @addTagHelper is a single token (Foo, Bar and "Baz, Bar").

This only works because we know what the syntax of Foo, Bar is supposed to be. We fully parse it, and then throw away the information so we can do it again later.

This kind of thing is a trap and should be avoided. We shipped this in 1.0.0 and it has to stay working, but it shouldn't infect the extensible directives feature.

[pranavkm]

Cool I'm all for normalizing it (one way or the other).

[rynowak]

Cool I'm all for normalizing it (one way or the other).

No. It has to be with quotes.

[pranavkm]

^ See title.