@inherits code generation #1261
Conversation
|
|
||
| namespace RazorCodeGen | ||
| { | ||
| public class MyBasePage<TModel> : RazorPage<TModel> |
There was a problem hiding this comment.
The tests don't need to be runnable/compile. I'd nuke this class for the sake of simplicity.
|
Ah, I didn't know we already had the infrastructure in place to give our codegen tests Import files. Neat. 🆙📅 |
| @@ -0,0 +1,2 @@ | |||
| @using RazorCodeGen | |||
| @inherits MyBasePage<string> base | |||
There was a problem hiding this comment.
Generally is a View you'd inherit from MyBasePage<TModel> because we expect there to be a ViewDataDictionary<TModel> property defined on the class.
I think we need a case where you inherit from MyBasePageForViews<TModel> with a traditional MVC view and a case where you inherit from MyBasePageForPages for an @page.
There was a problem hiding this comment.
Do you just mean that they should both be TModel and one of them should have @page? If not I'm not sure I follow since the models we're inheriting from don't exist.
| @@ -24,6 +23,35 @@ public class CodeGenerationIntegrationTest : IntegrationTestBase | |||
| private static readonly RazorSourceDocument DefaultImports = MvcRazorTemplateEngine.GetDefaultImports(); | |||
|
|
|||
| #region Runtime | |||
| [Fact] | |||
| public void Inherits_Runtime() | |||
There was a problem hiding this comment.
This specific test should be in the non-extensions codegen test project. @inherits is a core Razor directive. Same with its DesignTime counterpart.
| @@ -0,0 +1 @@ | |||
| @model MyModel | |||
There was a problem hiding this comment.
I misread and did the opposite of what you asked for, will flip it.
ryanbrandenburg
force-pushed
the
rybrande/InheritsCodeGeneration
branch
from
72d39f3
to
21b406b
Compare
|
🆙📅 hopefully I understood the asks here. |
| @@ -0,0 +1 @@ | |||
| @inherits MyPageModel<TModel> foo | |||
There was a problem hiding this comment.
lol wht's this foo at the end? It should totally trigger a parser error
There was a problem hiding this comment.
Also, Q: does this ViewImports impact other code generation tests or have we built in a convention to understand TestName_ImportsX?
There was a problem hiding this comment.
If that's the case do we want me to fix it here too, or did I misinterpret that line?
As for your second question we have a convetion to understand TestName_ImportsX, it's also used for the BasicImports test in Microsoft.AspNetCore.Razor.Language.Test.
There was a problem hiding this comment.
If that's the case do we want me to fix it here too, or did I misinterpret that line?
Woa, ya I'd definitely fix that one too.
As for your second question we have a convetion to understand TestName_ImportsX, it's also used for the BasicImports test in Microsoft.AspNetCore.Razor.Language.Test.
Awesomeneses 👍
ryanbrandenburg
force-pushed
the
rybrande/InheritsCodeGeneration
branch
from
0799eb9
to
5b7b131
Compare
|
🆙📅 |
|
@rynowak ready for your review. |
ryanbrandenburg
force-pushed
the
rybrande/InheritsCodeGeneration
branch
from
5b7b131
to
8af9f65
Compare
Fixes #1142.