Add binaries built for multiple windows platforms #605
Conversation
| EnsureBindingRedirects(assemblyFullPath, Path.GetFileName(dependencyToolPath)); | ||
| // For Full framework, we can directly invoke the <dependencyTool>.exe from the user's bin folder. | ||
| dependencyToolPath = Path.Combine(Path.GetDirectoryName(assemblyFullPath), Path.GetFileName(dependencyToolPath)); | ||
| // dependencyToolPath = Path.Combine(Path.GetDirectoryName(assemblyFullPath), Path.GetFileName(dependencyToolPath)); |
|
|
||
| private static bool IsNetCoreAppFramework(NuGetFramework framework) | ||
| { | ||
| //Only need to compare the framework name to be netcoreapp. Version doesn't matter. |
| else | ||
| { | ||
| throw new InvalidOperationException(Resources.AddDesignPackage); | ||
| dotnetCodeGenInsideManPath = Path.Combine(Path.GetDirectoryName(context.AssemblyFullPath), DESIGN_TOOL_NAME+".exe"); |
There was a problem hiding this comment.
DESIGN_TOOL_NAME + ".exe" (spacing)
| <Project> | ||
| <PropertyGroup> | ||
| <VersionPrefix>2.0.0</VersionPrefix> | ||
| <VersionPrefix>2.0.1</VersionPrefix> |
There was a problem hiding this comment.
Is this for the patch release?
There was a problem hiding this comment.
If @Eilon approves 😃
| <PackageTags>aspnetcore;codegenerator;scaffolding;visualstudioweb</PackageTags> | ||
| <PackageId>Microsoft.VisualStudio.Web.CodeGeneration.Design</PackageId> | ||
| <RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp2.0' ">win7-x86</RuntimeIdentifier> | ||
| <RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp2.0' ">win7-x64</RuntimeIdentifier> |
There was a problem hiding this comment.
Looks good. As discussed, you could simplify by this by either using this project do generate rid specific exes or have a common property file so you don't repeat the same details multiple times over.
|
Any update on this being released? |
|
@jamesabolton we don't have a precise ETA for the release, but we're setting up a temporary package feed where you'll be able to try out the pre-release builds of the patch. I'll update all the patch-related issues w/ info on the feed when it's available. We're working on getting the 1.0.x and 1.1.x patches ready first, and then the 2.0.x patch. |
|
Thank you, @Eilon. As noted in that other bug on dotnet/cli the new projects for Core 2.0 fail with an exception due to this issue. I haven't tested all of them but the MVC and Angular ones do not work. If you remove reference to the DLL then the web UI doesn't function. |
|
Is there anything we can do locally to get around this issue to work with the new templates and net standard 2.0 until a patch is released? I tried to downgrade the project that was created to 1.1/1.2 and that breaks various parts of the code in the template project. |
|
any new info about this issue? |
The only possible workaround at the moment is to set the RuntimeIdentifier to |
|
What about the other Windows RIDs, like |
|
@mshindal in general the |
7 participants
Changes include:
Add binaries for the following RIDs to the Microsoft.VisualStudio.Web.CodeGeneration.Design package
Also add a
AnyCPUPlatformTarget binary inlib\net461path to handle the case when the user project specifies<PlatformTarget>AnyCpu</PlatformTarget>without a RIDChange how we locate the inside-man to dispatch for net461 case to handle the fact that the compilation assemblies will no longer have the inside man for net461 case
Impact of packing 6 binaries instead of 2:
On local machine the
2.0.0package size is 55KB, the new package size is 127 KBcc @Eilon, @mlorbetske
Fixes #601