This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Fixing send/poll race #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a bug where the server would throw if send request is received before the first poll or sse request (#57). We will now delay send until the first poll or sse is received or reject the send request if poll or sse not received within a timeout Also making the connection not to be marked as Active upon reserving a connection. This enables cleaning up connections that were reserved but never used.
|
Why not always add the pipeline? We don't need the new TCS since we're doing to go this route. |
|
I can try that as well |
|
One problem with creating it on |
|
Looks like there is a race, if |
|
@BrennanConroy maybe we need to allow setting the format type as early as needed. |
|
Because you don't know when it is it would just mean you always need to send it. |
|
This will be solved differently (i.e. by specifying the format during negotiation) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug where the server would throw if send request is received before the first poll or sse request (#57). We will now delay send until the first poll or sse is received or reject the send request if poll or sse not received within a timeout
Also making the connection not to be marked as Active upon reserving a connection. This enables cleaning up connections that were reserved but never used.