This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Run only the expected tests #3009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on our chat, remember to remove .travis.yml from the PR. |
dougbu
force-pushed
the
dougbu/dnxcore.testing
branch
from
89c030d
to
c85d5d5
Compare
|
@dougbu - looking... |
Always glad to make failures visible 😈 |
| } | ||
| else | ||
| { | ||
| // Skip Mono if we're not running on Linux. |
There was a problem hiding this comment.
IsLinux is true on a Mac as well but I'll update the comment.
- do not use `DnxTest()` macro; it loops through frameworks as `test-package` target does already - `DnxTest()` also attempts to use `default` alias when testing `dnxcore50` though it's in `$env:Path` - therefore execute `dnx test` directly nit: use `IsLinux` where `IsMono` is the wrong question
dougbu
force-pushed
the
dougbu/dnxcore.testing
branch
from
c85d5d5
to
032d061
Compare
|
@moozzyk rebased and updated. Ready to 🚢 ? |
|
LGTM . 🚢 🇮🇹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DnxTest()macro; it loops through frameworks astest-packagetarget does alreadyDnxTest()also attempts to usedefaultalias when testingdnxcore50though it's in$env:Pathdnx testdirectlynit: use
IsLinuxwhereIsMonois the wrong question