-
Notifications
You must be signed in to change notification settings - Fork 224
Conversation
Based on our chat, remember to remove .travis.yml from the PR. |
89c030d
to
c85d5d5
Compare
@dougbu - looking... |
Always glad to make failures visible 😈 |
} | ||
else | ||
{ | ||
// Skip Mono if we're not running on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IsLinux
is true
on a Mac as well but I'll update the comment.
- do not use `DnxTest()` macro; it loops through frameworks as `test-package` target does already - `DnxTest()` also attempts to use `default` alias when testing `dnxcore50` though it's in `$env:Path` - therefore execute `dnx test` directly nit: use `IsLinux` where `IsMono` is the wrong question
c85d5d5
to
032d061
Compare
@moozzyk rebased and updated. Ready to 🚢 ? |
LGTM . 🚢 🇮🇹 |
DnxTest()
macro; it loops through frameworks astest-package
target does alreadyDnxTest()
also attempts to usedefault
alias when testingdnxcore50
though it's in$env:Path
dnx test
directlynit: use
IsLinux
whereIsMono
is the wrong question