Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

Conversation

vijayrkn
Copy link
Contributor

Copy link
Contributor

@mlorbetske mlorbetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run this by Daniel & Sayed - I imagine this is fine, as it's unlikely that people are packing web projects, but we should double check

@davidfowl
Copy link
Member

I think this is fine.

@vijayrkn vijayrkn merged commit 633276b into dev Mar 24, 2017
@vijayrkn vijayrkn deleted the IsPackable branch May 16, 2017 17:26
@marcusien
Copy link

marcusien commented Aug 29, 2017

As said on my issue (https://github.com/dotnet/cli/issues/7539) , I don't think this behavior is fine cause there's no reason not to do it, and no documentation or message is produced when we try to pack a web project.

A web project can have "Console application" as Output type but we can also change it to be "Class library".

@DamonStamper
Copy link

This change has generated https://github.com/aspnet/websdk/issues/228.

The change affecting Microsoft.NET.Sdk.Web makes it annoying. Trying to be smarter than the end user and not telling the end user makes it irritating--especially when there are unintended side effects.

@bgoerdt
Copy link

bgoerdt commented Nov 20, 2017

It would be useful to have a warning stating that the web project is not configured to be packable when dotnet pack runs.

@robertbird
Copy link

Agree with @bgoerdt, would be really useful to see some output warning me that my project is not being packed intentionally.

I ran into this via https://github.com/dotnet/cli/issues/7539 when trying to pack my web project for Octopus Deploy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants