Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting IsPackable to false in websdk #165

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
7 participants
@vijayrkn
Copy link
Contributor

commented Mar 24, 2017

@mlorbetske
Copy link
Contributor

left a comment

We should run this by Daniel & Sayed - I imagine this is fine, as it's unlikely that people are packing web projects, but we should double check

@davidfowl

This comment has been minimized.

Copy link
Member

commented Mar 24, 2017

I think this is fine.

@marcusien

This comment has been minimized.

Copy link

commented Aug 29, 2017

As said on my issue (dotnet/cli#7539) , I don't think this behavior is fine cause there's no reason not to do it, and no documentation or message is produced when we try to pack a web project.

A web project can have "Console application" as Output type but we can also change it to be "Class library".

@DamonStamper

This comment has been minimized.

Copy link

commented Nov 10, 2017

This change has generated #228.

The change affecting Microsoft.NET.Sdk.Web makes it annoying. Trying to be smarter than the end user and not telling the end user makes it irritating--especially when there are unintended side effects.

@bgoerdt

This comment has been minimized.

Copy link

commented Nov 20, 2017

It would be useful to have a warning stating that the web project is not configured to be packable when dotnet pack runs.

@robertbird

This comment has been minimized.

Copy link

commented Dec 8, 2017

Agree with @bgoerdt, would be really useful to see some output warning me that my project is not being packed intentionally.

I ran into this via dotnet/cli#7539 when trying to pack my web project for Octopus Deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.