fix: tty test #160
Closed
fix: tty test #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I test a program that uses `isatty`, it will detect that it is not a tty even if it is a tty. The cause was that the pipe was passed to stdin even when `write_stdin` was not used. Fixed to pass pipe to stdin only when `write_stdin`.
|
I feel like this needs more description and discussion. Please open an Issue first for that. |
|
See also #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I test a program that uses
isatty, assert_cmd detects that it is not a tty even if it is a tty.It is caused by passing pipe to stdin even when
write_stdinis not used.Fixed to pass pipe to stdin only when use
write_stdin.