Skip to content
This repository has been archived by the owner on Nov 20, 2022. It is now read-only.

add range set assert #45

Closed
wants to merge 3 commits into from
Closed

add range set assert #45

wants to merge 3 commits into from

Conversation

groov1kk
Copy link

New RangeSetAssert

@joel-costigliola
Copy link
Member

Thanks, I will review your PR by the end of the year, ping me if I don't ;-)

@groov1kk
Copy link
Author

groov1kk commented Jan 8, 2020

Thanks, I will review your PR by the end of the year, ping me if I don't ;-)

Hello. New year is stated :) Any news about my pull request?

@joel-costigliola
Copy link
Member

Sorry it slipped out of my mind, thanks for the reminder

joel-costigliola
joel-costigliola suggested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge PR thanks!
Overall it is really good, a few rename needed and few more tests and we should be good!

src/main/java/org/assertj/guava/api/Assertions.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/guava/api/InstanceOfAssertFactories.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/guava/api/RangeAssert.java Show resolved Hide resolved
src/main/java/org/assertj/guava/api/RangeAssert.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/guava/api/RangeAssert.java Show resolved Hide resolved
src/main/java/org/assertj/guava/internal/RangeSets.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/guava/internal/RangeSets.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/guava/internal/RangeSets.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/guava/api/RangeSetAssert_containsAnyOf_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/guava/api/RangeSetAssert_encloses_Test.java Show resolved Hide resolved
@groov1kk
Copy link
Author

Looks like I finished with fixes.

@joel-costigliola
Copy link
Member

Thanks, I will review the changes very soon!

joel-costigliola pushed a commit that referenced this pull request Feb 1, 2020
@joel-costigliola
Add range set assert.
fc49b4a 
Fixes #45
@joel-costigliola
Copy link
Member

Integrated thanks @groov1kk!
I have used @SafeVarargs to avoid warnings, not compatible with soft assertions but since there are iterable alternative of varargs assertions, that's an acceptable fallback mechanism IMHO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joel-costigliola joel-costigliola Awaiting requested review from joel-costigliola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groov1kk @joel-costigliola