Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildProduction should deduce root from input HTML-files #12

Closed
msiebuhr opened this issue Jul 12, 2012 · 3 comments
Closed

buildProduction should deduce root from input HTML-files #12

msiebuhr opened this issue Jul 12, 2012 · 3 comments

Comments

@msiebuhr
Copy link

Random idea for buildProduction:

Deduce the --root-parameter from the topmost common parent directory of the given input HTML-files.

(Don't know if that makes sense in larger setups, though.)

@Munter
Copy link
Member

Munter commented Jul 13, 2012

The basic idea is good, but I am not sure if it clashes with some previous design decisions. I guess @papandreou remembers more about the reasoning behind this.

As I see ti you might need to specify a document root like http-pub if you build a Js-bundle based on http-pub/js/myApplication/bundle.js because there might be relations as far out as the given root.

@papandreou
Copy link
Member

We have at least one use case where the root !== the topmost dir with html files in it. Would you get rid of the switch completely or just change its default value?

@Munter
Copy link
Member

Munter commented Jul 14, 2012

I guess we could keep the switch, but make it optional and default to the path of the first argument.
How would we handle when there are multiple arguments though?
Only extrapolate the root from the path if there is one argument, and require a specific root if there are multiple arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants