-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mingw debug build #2418
Fix mingw debug build #2418
Conversation
* Add notes on building with MinGW to Build.md
…but have not verified this. Also, if anyone tries to debug StepFileGen1.cpp on MinGW, the debug info may not be there, but I think this is the best we can do.
* Add check on MinGW compiler version to force compliance. * Closes assimp#2315 ?
@kimkulling I've been working on the mingw issues too. Not entirely successful, but thought I'd put this up so that we don't duplicate effort/ so that we can share info. I got the file too large error to go away using per-file compiler flags, but am now running into what seems to be a duplicate of #1886 (all the debug symbols are exported and dlls can export a max of ~65k symbols) |
Cool, nice to see that someone trying to deal with mingw build. Currently I am using only release build. |
Merged, thanks a lot for the contribution. |
MinGW compiler version 7.0 is a bold claim. I think 6.3.0 would be fine to use at the minimum. Have to check the earliest possible that can be used. I come from issue #2315 . Anything newer than the end of release 5 may have a good chance of working. However, I couldn't find a google result of this. Only more issues hitting from page of this issue. |
@tilkinsc That's an absolutely fair point. I should definitely clarify what I meant, I'll PR it in a bit. What is actually being checked for and what I said, albeit in a very unclear way is that the version of g++ that mingw supplies is >7. E.g. mingw-w64 v5.0 is fine I believe (and I think that's what I tested it with, though I'll go back and check), since it supplies g++ 7.3.0. g++ version != mingw version. I checked it that way because cmake can check the compiler version much more easily than the "mingw version". So basically, iirc, Mingw 4.0 has issues and doesn't have g++ > 7.0.0, mingw-w64 5.0 & 6.0 both supply g++ > 7.0.0. But still, if you can get an older version of g++-mingw-w64++ to work, I'll happily update the version. Iirc did some digging and couldn't find exactly what version it was added in, so I erred on the side of what I knew worked rather than trying to guess what version they introduced it in (the last thing I wanted to do was subject Kim to people saying "it says it should work but it doesn't"). Also, could you check whether the check properly flags the broken version of mingw you experienced the issue on? As mentioned, mingw version is separate equal g++ version, so I want to make sure I got it right. Also, @kimkulling the last bullet point was listed as wip - 2406 should remain open. Sorry about that, was going to come back and finish that but I've been crazy busy the last few weeks. |
If I get the nerve to test it I'll happily! :) |
-mbig_obj
not supported #2315 ?)