Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in ob-async-org-babel-execute-src-block: Symbol’s function definition is void: -if-let #25

Closed
2 of 3 tasks
bgoodr opened this issue Apr 15, 2018 · 2 comments
Closed
2 of 3 tasks

Comments

@bgoodr
Copy link

bgoodr commented Apr 15, 2018

Checklist

  • I followed the troubleshooting guide and it did not address my issue
  • I've included a link to a Github Gist with the full contents of my troubleshooting.org buffer
  • Each section below is filled in and includes sufficient detail to reproduce the issue

Expected Behavior

Should just work without a error about void function.

Actual Behavior

Got: error in process sentinel: Symbol’s function definition is void: -if-let

Steps to Reproduce

See the troubleshooting.org file linked below in a gist for my analysis. See the very end of it.

Side note: the troubleshooting.org file references the need to manually update a hook function, but the code indicates that is not needed. installing the package from Melpa did not automatically update a hook function and I conclude the troubleshooting.org file is out of date with what is actually required.

Troubleshooting Artifacts

Here is the link to my copy of the troubleshooting.org file: https://gist.github.com/bgoodr/ae0e048bb5fe6e660bfff3ac96744cf8

astahlman added a commit that referenced this issue Apr 23, 2018
We've been using the `-if-let` macro from dash.el without every
explicitly requiring the dash library. dash is a common library, so
we've gotten away with it until now - see [1].

[1] #25
@astahlman
Copy link
Owner

Thanks for reporting @bgoodr, this was definitely a bug - the -if-let macro cromes from the dash package, which ob-async depends on but didn't explicitly declare. I've just merged #26 which makes the dependency explicit.

Side note: I considered just using if-let, but it looks like that wasn't built in to Emacs before Emacs 25. If and when we drop support for Emacs 24, we could eliminate the dependency on dash by changing -if-let to if-let

@bgoodr
Copy link
Author

bgoodr commented Apr 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants