Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit tests from precommit hooks #51

Merged
merged 3 commits into from
Mar 20, 2022
Merged

Remove unit tests from precommit hooks #51

merged 3 commits into from
Mar 20, 2022

Conversation

astariul
Copy link
Owner

πŸ”οΈ Description

This PR removes pytest from pre-commit hooks. Also update docs.

🧐 Context

See this comment. Basically we don't want to run unit tests in pre-commits, because tests might be slow, but for the sake of developpers, we want fast hooks.

⚠️ Side-effects / Shortcomings

None

βœ… How this was tested ?

Docs building locally.

🌱 Checklist

  • Perform self-review of my own code
  • Comment the code, particularly in hard-to-understand areas
  • Update the documentation accordingly to the new code
  • Lint / format the code
  • Update existing tests / Add new tests
  • Tests are passing locally

@astariul astariul self-assigned this Mar 20, 2022
@astariul astariul merged commit 3dff7df into main Mar 20, 2022
@astariul astariul deleted the precommit_no_tests branch March 20, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant