-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve WebVTT tags in subtitle lines #97
Conversation
Hi @asticode , could you please have a look? |
6f745f2
to
f85fc97
Compare
f85fc97
to
9d10b07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 final minor changes and I'll merge this PR 👍
9d10b07
to
d7ab41f
Compare
@asticode , thank you for your ideas! After merging the PR, would you mind creating a release tag for new changes? |
FYI I've created a Thanks again for the PR ❤️ |
Hi @asticode , |
Yeah there was a mixup, I've created a |
Thank you! It's working now. |
Hi all,
WebVTT STYLE block is CSS and it allow to write custom CSS class or tag in xml to applied to the lines of WebVTT, also, some default tag like tag i (italic), b (bold), u (underline), etc are supported too, for example:
So, I add these change to preserve the tags in WebVTT files. This will be convenient if someday, we decide to convert styling from WebVTT to TTML or another format.
According to WebVTT format at: https://www.w3.org/TR/webvtt1/