Added update function to options-query fixes #74. #109
Conversation
| @@ -342,6 +350,7 @@ define([ | |||
| reset: function (array) { | |||
| if (arguments.length === 0) { | |||
| this.removeAll(); | |||
| this.update(); | |||
There was a problem hiding this comment.
I believe this should be removed because the last line in removeAll method is update() and this call will only add overhead to the performance.
There was a problem hiding this comment.
You are totally right. Iremoved it.
|
I can suggest a thing when making changes that affect core logic. I usually take the jsblocks-shopping-example replace it with the newest version of the code and run Can you do this with these changes so we are sure nothing broke before merging this? |
Caused by not updating ``VirtualELement._state`` in ``_executeAttributeExpressions`` if the Element is not Virtual. Fixed by updateing as long as '_state' exists.
Added call to observable.update() in array-observable.reset(). Require as the data-query.update() function will get called there.
An way for (internal) Methods to get the value with out beeing registered by the Observer. For cases where you need the observable value but don't want to get updated if it changes (In my case the update function of the options data-query)
observable.update now will not subscribe it's observable to the current element (e.g. data-query).
Update will check for selected value inside the updated collection. And update the value to the first 'data-rel="header"' or when provided 'caption' option or otherwise to the first value of the collection. Closes astoilkov#74.
Added update function to options-query fixes #74.
Initial problem with not updating attributes in this edgecase is fixed through updating the
_stateproperty of an VirtualElement as long as the property exsits (and changes).Added call to
observable.update()in array-oservablesreset()function.Did not find a case where this could break something, correct me if I'm wrong.
Added a function called
observable._getValue()which just returns the value but does not subscribe it to theObserver. I need this for theupdatefunction of theoptionsdata-query.Also
observable.updatenow not subscribes observables or to be more correct it creates and drops a new Observer stack.I couldn't find a case where it breaks something as the call that causes the subsciption is caused by and on already subscribed elements.
Fixed a bug with the new
Expression.NodeWiserendering that caused some wrong updates in the select.Added the
update-function to theoptions-data-query and tests for it which causes following behaviour:On update(reset, remove, ...) of the collection:
data-role="header"(=caption in the queries options) this option is used.data-role="header"-option the value is set to the first item of the collection.Hope I've been clear enough. Ask questions if you have some 😄.
Fixes #74.