Implements checkbox groups and fixes false negative select multple attribute check. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2016 23:54
They didn't work as the vale of the 'multiple' in '<select multiple>' is '' and therefore falsy.
The 'checked'/'attr'-data-query with 'checked' as attribute will accept arrays/array-observables as the 'value' parameter and try to find their value in the array to set the value and add their value to the array when checked.
|
I like that. Excellent work. |
astoilkov
added a commit
that referenced
this pull request
Jan 8, 2016
Implements checkbox groups and fixes false negative select multple attribute check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements checkbox groups and fixes false negative (falsy) select multiple detection.
Here a working example with a built version of it:https://jsfiddle.net/a22gvf9u/
Closes #123