Second xpath() approach for XML version detection #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading my local environment from PHP 5.4 to PHP 5.5, suddenly the get_module_version() function failed. After some research I found that the xpath() method of SimpleXML has issues with the // syntax to find the version-element. This patch adds a workaround for detecting the version in a different way, if the original approach fails (like in my case).
astorm
added a commit
that referenced
this pull request
Jun 23, 2014
Second xpath() approach for XML version detection
|
Any idea why |
|
Good question. No. It seemed as if the |
|
Weird — if you have a moment (and there's no sensative information), would you mind adding your config.xml to this issue thread so I can look into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading my local environment from PHP 5.4 to PHP 5.5, suddenly the get_module_version() function failed. After some research I found that the xpath() method of SimpleXML has issues with the // syntax to find the version-element. This patch adds a workaround for detecting the version in a different way, if the original approach fails (like in my case).