Add a 'run' setting to only run Ruff on-save #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added a commit
to astral-sh/ruff-vscode
that referenced
this pull request
Jun 17, 2023
## Summary Now supported in the LSP (astral-sh/ruff-lsp#146): The API exactly mimics that of the [ESLint extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint): we have a new setting, `run`, that accepts either `onType` (default) or `onSave`. Closes #110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've had some reports of the extension causing high CPU usage (astral-sh/ruff-vscode#110). This PR enables users to set the extension to only run on-save, rather than on every keystroke.
The API exactly mimics that of the ESLint extension: we have a new setting,
run, that accepts eitheronType(default) oronSave.