Updates to CI workflow #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well actually to unblock installation of a newer version of Black we'd need to split the linting dependencies into a separate installation category or add a split to the Black version used depending on the Python version which would not require this change but isn't something we want because then CI needs to pass for multiple versions of Black. |
|
Actually, pytest dropped support for 3.7 in pytest-dev/pytest#11152 so we cannot run tests in CI even if we separate the linting jobs. |
|
Better handled in #187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test plan
Verify that CI runs correctly on this pull request