Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make flake8-quotes descriptions consistent with default settings #5496

Closed
trag1c opened this issue Jul 3, 2023 · 2 comments · Fixed by #5507
Closed

Make flake8-quotes descriptions consistent with default settings #5496

trag1c opened this issue Jul 3, 2023 · 2 comments · Fixed by #5507
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@trag1c
Copy link
Contributor

trag1c commented Jul 3, 2023

34882

Whether single quotes are preferred over double quotes, or vice versa, depends on the docstring-quotes, inline-quotes and multiline-quotes settings, which all default to "double". I think it would make more sense to make the descriptions prefer double quotes as well.
@charliermarsh
Copy link
Member

Makes sense.

@charliermarsh charliermarsh added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 3, 2023
@charliermarsh
Copy link
Member

(If anyone's interested, we just need to reverse the order of the branches in the violation definition -- the docs just render the first one.)

@charliermarsh charliermarsh mentioned this issue Jul 4, 2023
Merged
charliermarsh added a commit that referenced this issue Jul 4, 2023
@charliermarsh
Update documentation to list double-quote preference first (#5507)
75da72b 
Closes #5496.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation to list double-quote preference first astral-sh/ruff
2 participants
@charliermarsh @trag1c