Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx documentation style to pydocstyle config #6606

Open
Eutropios opened this issue Aug 16, 2023 · 14 comments
Open

Add sphinx documentation style to pydocstyle config #6606

Eutropios opened this issue Aug 16, 2023 · 14 comments
Labels
docstring Related to docstring linting or formatting

Comments

@Eutropios
Copy link
Contributor

Eutropios commented Aug 16, 2023

Addition of sphinx documentation style to pydocstyle config as so:

[tool.ruff.pydocstyle]
    convention = "sphinx"

Currently pep257, google, and numpy documentation styles are supported. It'd be nice to have this major documentation style added as well.

@charliermarsh charliermarsh added the docstring Related to docstring linting or formatting label Aug 16, 2023
@charliermarsh
Copy link
Member

We can probably add a convention that's compatible, but there would also be necessary work to actually support parsing Sphinx docstrings (e.g., PyCQA/pydocstyle#595). pydocstyle itself does not support this.

@charliermarsh charliermarsh added the needs-decision Awaiting a decision from a maintainer label Aug 16, 2023
@Eutropios
Copy link
Contributor Author

Alright, so as far as I know, the necessary pull requests to pydocstyle have been made as of 5 hours ago. Relevant commit here: PyCQA/pydocstyle/commit.

@LecrisUT
Copy link

Related, it would be nice to get a check when a different convention is used.

@charliermarsh charliermarsh removed the needs-decision Awaiting a decision from a maintainer label Nov 22, 2023
@charliermarsh
Copy link
Member

(Removing needs-decision since we should support this now.)

@Eutropios
Copy link
Contributor Author

Sounds great! Let me know if there's anything I can do to help.

@winwinashwin
Copy link

+1 on this feature. Any updates on sphinx support?

@DanPaseltiner
Copy link

Ditto @winwinashwin. We would adopt Ruff immediately on this project it there was sphinx support. Unfortunately, we have a code base full of Sphinx style docstrings and need to implement linting on them.

@jaladh-singhal
Copy link

Hi, just checking if/when this will be available?

BTW thanks for making this super awesome tool!

@Lassii-
Copy link

Lassii- commented Aug 12, 2024

Hello,

Also wondering if there's any plan updates to this? The project I work for is also looking for the support.

@seppzer0
Copy link

seppzer0 commented Oct 17, 2024

@charliermarsh , @zanieb , hi! Sorry for pinging directly on this, I see this as an only option to revive this ticket.

I noticed that this was going to be supported, but there haven't been news for a while. Could you please inform whether this is going to be supported in ruff?

Looking forward to bundle this with uv usage to have a fully configured ecosystem for our projects.

@seppzer0
Copy link

@seppzer0

This comment was marked as spam.

@MichaReiser
Copy link
Member

MichaReiser commented Oct 26, 2024

@seppzer0 I understand that this feature is important to you but please stop pinging people. We get a lot of notifications every day and pinging only results in additional distractions, meaning we have less time to do actual feature work.

We plan to look at linked PRs but it might take a while because we have to balance it with other features that we want to ship. We'll make sure to update this issue or the linked PRs if there's an update.

@seppzer0
Copy link

@MichaReiser , thank you for your response! I do understand that pinging people is not great, unfortunately though it is often the only way to remind of the topic at hand.

Thank you once again for your work! Looking towards to this great feature 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docstring Related to docstring linting or formatting
Projects
None yet
Development

No branches or pull requests

9 participants