-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting changes to enable more Ruff Rules #214
Conversation
…allation and Ruff
Ruff does not yet support Sphinx-style docstrings 🙃 astral-sh/ruff#6606 |
Removed the docstring check because sphinx isn't yet supported. Left the updates though because when sphinx is supported it'll be less work to modify them than to do it over again |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 79.38% 78.84% -0.54%
==========================================
Files 23 23
Lines 1033 1035 +2
==========================================
- Hits 820 816 -4
- Misses 213 219 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reverted the docstring stuff because sphinx doesn't like it :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Mostly converting .format()
strings to f-strings, and sorting imports, but still nice to have.
Might be nice to get some DS eyes on this since this is mostly a DS codebase, but I'll leave that up to you. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #213