Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter panic with comment after parenthesized dict value #5293

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix formatter panic with comment after parenthesized dict value #5293

merged 1 commit into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. Fix formatter panic with comment after parenthesized dict value 

    ## Summary

This snippet used to panic because it expected to see a comma or something similar after the `2` but met the closing parentheses that is not part of the range and panicked
```python
a = {
    1: (2),
    # comment
    3: True,
}
```

Originally found in https://github.com/bolucat/Firefox/blob/636a717ef025c16434997dc89e42351ef740ee6b/testing/marionette/client/marionette_driver/geckoinstance.py#L109

This snippet is also the test plan.
    @konstin
    konstin committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b963c7f View commit details
    Browse the repository at this point in the history