Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge clippy and clippy (wasm) jobs on CI #5447

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Merge clippy and clippy (wasm) jobs on CI #5447

merged 3 commits into from
Jul 4, 2023

Commits on Jun 29, 2023

  1. Merge clippy and clippy (wasm) jobs on CI 

    ## Summary

The clippy wasm job rarely fails if regular clippy doesn't, wasm clippy still compiles a lot of native dependencies for the proc macro and we have less CI jobs overall, so i think this an improvement to our CI.

```shell
$ CARGO_TARGET_DIR=target-wasm cargo clippy -p ruff_wasm --target wasm32-unknown-unknown --all-features -j 2 -- -D warnings
$ du -sh target-wasm/*
12K	target-wasm/CACHEDIR.TAG
582M	target-wasm/debug
268M	target-wasm/wasm32-unknown-unknown
```

## Test plan

n/a
    @konstin
    konstin committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    36a163b View commit details
    Browse the repository at this point in the history

  2. Trigger CI

    @konstin
    konstin committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    2be8815 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. rerun CI

    @konstin
    konstin committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    97d921a View commit details
    Browse the repository at this point in the history