Use crates.io unicode_names2 0.6.0

[konstin]

Update unicode_names2 to the crates.io release 0.6.0, removing a git dependency.

@youknowone As far as i can tell, all changes from https://github.com/youknowone/unicode_names2 have been merged into https://github.com/progval/unicode_names2, is it correct that all changes needed for the RustPython parser are in the 0.6.0 release on crates.io?

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

[charliermarsh]

Cool with this assuming it contains all the changes.

[youknowone]

I wasn't following up this issue for a while.
As I understand, this patch is required to keep compatibility. progval/unicode_names2#12
But let me look them in again for next a few weeks.
I was not able to working on open source projects for a while due to other stuff. it will takes a few more weeks.

[charliermarsh]

Ah yeah, I think upstream is still missing some changes that we need.

[konstin]

i think we need progval/unicode_names2#12, but i don't understand how since none of our tests are failing without it. Upstream is maintained and has just published a 1.0.0, so i'm even more motivated to migrate

[charliermarsh]

I think this shows a failing test case: RustPython/RustPython#4566

[charliermarsh]

Unless it no longer fails after switching to the main channel, of course.

[konstin]

thanks for link! I added the test, it seems that this is already passing.

[charliermarsh]

As annoying as it is... I'd really love to understand why it works now (and didn't before) prior to merging. Does that snippet fail on 0.6.0 (non-Git, like before we pinned)?

[konstin]

oh, i realized i actually updated only one of two unicode_names2 usages. I updated the other too, and now the test fails as expected.

[manmartgarc]

Hey, just checking in on this. I was able to use a temporary LibCST crates on #7179. As far as I know unicode_names2 is the only other git dependency left to vanquish. What is left to do to merge this change?

[konstin]

I've checked and the relevant PR was merged in the mean time (progval/unicode_names2#12). I've asked for a crates.io release: progval/unicode_names2#28

[charliermarsh]

Thanks @manmartgarc. By the way: I temporarily moved LibCST back to a Git dependency so that we could get out Python 3.12 support today, but I'll move it back to crates as soon as they publish a new version.

[konstin]

Current dependencies on/for this PR:

• main
  • PR Use crates.io unicode_names2 0.6.0 #6478 👈

This comment was auto-generated by Graphite.

[konstin]

The maintainer reacted really quickly, this is now ready to be merged

[konstin]

Made this consistent while i was at it

[charliermarsh]

Great!

[codspeed-hq]

CodSpeed Performance Report

Merging #6478 will degrade performances by 3.69%

_{Comparing unicode_names2_0-6-0 (7ab46fc) with main (c6d0bdd)}

Summary

❌ 1 (👁 1) regressions
✅ 24 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	unicode_names2_0-6-0	Change
👁	linter/default-rules[large/dataset.py]	92.5 ms	96 ms	-3.69%

[youknowone]

👍