Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LibCST #7062

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Update LibCST #7062

merged 1 commit into from
Sep 3, 2023

Conversation

dhruvmanila
Copy link
Member

Summary

This PR updates the revision of LibCST dependency to Instagram/LibCST@9c263aa
inorder to fix #4899

Test Plan

The test case including the carriage return (\r) character was added for
F504 and then cargo test.

fixes: #4899

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila added the dependencies Pull requests that update a dependency file label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@MichaReiser
Copy link
Member

It improves the performance of two linter benchmarks.

@dhruvmanila dhruvmanila added the bug Something isn't working label Sep 3, 2023
@dhruvmanila dhruvmanila merged commit 4eaa412 into main Sep 3, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/update-libcst branch September 3, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F504: Carriage return prevents expression extraction
3 participants