Avoid attempting to fix NPY001 with overridden builtins

crates/ruff/resources/test/fixtures/numpy/NPY001.py

@@ -18,3 +18,8 @@
 )
 
 _ = arr.astype(np.int)
+
+# Regression test for: https://github.com/astral-sh/ruff/issues/6952
+from numpy import float
+
+float(1)

crates/ruff/src/rules/numpy/rules/deprecated_type_alias.rs

@@ -1,7 +1,6 @@
-use ruff_python_ast::Expr;
-
-use ruff_diagnostics::{AlwaysAutofixableViolation, Diagnostic, Edit, Fix};
+use ruff_diagnostics::{AutofixKind, Diagnostic, Edit, Fix, Violation};
 use ruff_macros::{derive_message_formats, violation};
+use ruff_python_ast::Expr;
 use ruff_text_size::Ranged;
 
 use crate::checkers::ast::Checker;
@@ -34,16 +33,18 @@ pub struct NumpyDeprecatedTypeAlias {
     type_name: String,
 }
 
-impl AlwaysAutofixableViolation for NumpyDeprecatedTypeAlias {
+impl Violation for NumpyDeprecatedTypeAlias {
+    const AUTOFIX: AutofixKind = AutofixKind::Sometimes;
+
     #[derive_message_formats]
     fn message(&self) -> String {
         let NumpyDeprecatedTypeAlias { type_name } = self;
         format!("Type alias `np.{type_name}` is deprecated, replace with builtin type")
     }
 
-    fn autofix_title(&self) -> String {
+    fn autofix_title(&self) -> Option<String> {
         let NumpyDeprecatedTypeAlias { type_name } = self;
-        format!("Replace `np.{type_name}` with builtin type")
+        Some(format!("Replace `np.{type_name}` with builtin type"))
     }
 }
 
@@ -73,15 +74,17 @@ pub(crate) fn deprecated_type_alias(checker: &mut Checker, expr: &Expr) {
             expr.range(),
         );
         if checker.patch(diagnostic.kind.rule()) {
-            diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
-                match type_name {
-                    "unicode" => "str",
-                    "long" => "int",
-                    _ => type_name,
-                }
-                .to_string(),
-                expr.range(),
-            )));
+            let type_name = match type_name {
+                "unicode" => "str",
+                "long" => "int",
+                _ => type_name,
+            };
+            if checker.semantic().is_builtin(type_name) {
+                diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
+                    type_name.to_string(),
+                    expr.range(),
+                )));
+            }
         }
         checker.diagnostics.push(diagnostic);
     }

crates/ruff/src/rules/numpy/snapshots/ruff__rules__numpy__tests__numpy-deprecated-type-alias_NPY001.py.snap

@@ -129,6 +129,8 @@ NPY001.py:20:16: NPY001 [*] Type alias `np.int` is deprecated, replace with buil
 19 | 
 20 | _ = arr.astype(np.int)
    |                ^^^^^^ NPY001
+21 | 
+22 | # Regression test for: https://github.com/astral-sh/ruff/issues/6952
    |
    = help: Replace `np.int` with builtin type
 
@@ -138,5 +140,17 @@ NPY001.py:20:16: NPY001 [*] Type alias `np.int` is deprecated, replace with buil
 19 19 | 
 20    |-_ = arr.astype(np.int)
    20 |+_ = arr.astype(int)
+21 21 | 
+22 22 | # Regression test for: https://github.com/astral-sh/ruff/issues/6952
+23 23 | from numpy import float
+
+NPY001.py:25:1: NPY001 Type alias `np.float` is deprecated, replace with builtin type
+   |
+23 | from numpy import float
+24 | 
+25 | float(1)
+   | ^^^^^ NPY001
+   |
+   = help: Replace `np.float` with builtin type