Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.1.12 #9475

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Bump version to v0.1.12 #9475

merged 9 commits into from
Jan 11, 2024

Conversation

charliermarsh
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

pandas-dev/pandas (+0 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

- pandas/core/internals/construction.py:161:5: PLR0917 Too many positional arguments (6/5)
- pandas/core/internals/construction.py:237:5: PLR0917 Too many positional arguments (6/5)
- pandas/core/internals/construction.py:441:9: PLC0415 `import` should be at the top-level of a file
- pandas/core/internals/construction.py:784:5: PLC0415 `import` should be at the top-level of a file

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PLR0917 2 0 2 0 0
PLC0415 2 0 2 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link

codspeed-hq bot commented Jan 11, 2024

CodSpeed Performance Report

Merging #9475 will degrade performances by 4.35%

Comparing charlie/bump (97702d9) with main (eb4ed24)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/bump Change
parser[numpy/ctypeslib.py] 12.2 ms 12.8 ms -4.35%

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions ;)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
Comment on lines 20 to 21
- [\`flake8-bugbear\`] Include subscripts and attributes in static key rule ([#9416](https://github.com/astral-sh/ruff/pull/9416))
- [\`flake8-bugbear\`] Support variable keys in static dictionary key rule ([#9411](https://github.com/astral-sh/ruff/pull/9411))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are both changes to RUF011 -- is it correct to classify them as flake8-bugbear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. This rule was moved to flake8-bugbear, but that PR hasn't actually merged yet, my mistake!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
charliermarsh and others added 5 commits January 11, 2024 15:30
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh
Copy link
Member Author

Thanks @AlexWaygood, sloppy work on my part, appreciate it :)

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Hyped to use some of these in my projects

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh charliermarsh merged commit 55f8f3b into main Jan 11, 2024
35 checks passed
@charliermarsh charliermarsh deleted the charlie/bump branch January 11, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants