Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range formatting: Fix invalid syntax after parenthesizing expression #9751

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Range formatting: Fix invalid syntax after parenthesizing expression #9751

merged 3 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Remove implicit source position from string tokens 

    Require explicit `FormatElement::SourcePosition` elements over implicitly adding a source mapping for every token. This has the downside that it requires more `FormatElement`s to achieve a source mapping at the same detail level as today. However, we don't have a use case for token by token source maps today. We only want to map node positions where this is more than sufficient.
    @MichaReiser
    MichaReiser committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c262a41 View commit details
    Browse the repository at this point in the history

  2. Range formatting: Fix invalid syntax after parenthesizing expression

    @MichaReiser
    MichaReiser committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    22ba608 View commit details
    Browse the repository at this point in the history

  3. fixup! Remove implicit source position from string tokens

    @MichaReiser
    MichaReiser committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    59a8f29 View commit details
    Browse the repository at this point in the history