Add persistent storage of installed toolchains #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/data-dir-toolchain
branch
4 times, most recently
from
33cbd0d
to
9843b5b
Compare
zanieb
force-pushed
the
zb/data-dir-toolchain
branch
from
9843b5b
to
b159182
Compare
|
I'm going to write a |
|
There's an open question about versioning. We probably shouldn't just discard old buckets like we do in the cache. Maybe we can version and write explicit migrations? |
charliermarsh
approved these changes
May 24, 2024
|
Updated to include #3726 which wouldn't pass CI otherwise since it was unused. |
zanieb
force-pushed
the
zb/data-dir-toolchain
branch
2 times, most recently
from
0454869
to
9517162
Compare
konstin
approved these changes
May 24, 2024
| @@ -144,7 +144,6 @@ jobs: | |||
|
|
|||
| - name: "Cargo test" | |||
| run: | | |||
| export UV_BOOTSTRAP_DIR="$(pwd)/bin" | |||
This was referenced May 24, 2024
charliermarsh
force-pushed
the
zb/data-dir-toolchain
branch
from
9517162
to
8f2c59b
Compare
charliermarsh
pushed a commit
that referenced
this pull request
May 27, 2024
Prepares for merge of #3797, gating managed toolchain discovery with the preview flag to lower risk of releasing. e.g. ``` ❯ cargo dev -q fetch-python ❯ cargo run -q -- venv --python 3.11 Using Python 3.11.9 interpreter at: /opt/homebrew/opt/python@3.11/bin/python3.11 Creating virtualenv at: .venv Activate with: source .venv/bin/activate ❯ cargo run -q -- venv --preview --python 3.11 Using Python 3.11.7 interpreter at: /Users/zb/Library/Application Support/uv/toolchains/cpython-3.11.7-macos-aarch64-none/install/bin/python3 Creating virtualenv at: .venv Activate with: source .venv/bin/activate ``` We'll add automatic fetching of managed interpreters later.
charliermarsh
pushed a commit
that referenced
this pull request
May 27, 2024
Follow-up to #3797 to clean up the test isolation in `uv-interpreter`. I still want to expose a CLI at some point like `uv python <...>` for discovery and test from there, hopefully this will make that transition simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #3726
Moves toolchain storage out of
UV_BOOTSTRAP_DIR(./bin) into the proper user data directory as defined by #3726.Replaces
UV_BOOTSTRAP_DIRwithUV_TOOLCHAIN_DIRfor customization. Installed toolchains will be discovered without opt-in, but the idea is still that these are not yet user-facing.