Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all extras when generating lockfile #3912

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

This PR just ensures that when running uv lock (or uv run), we lock with all extras. When we later install, we'll also install with all extras, but that will be changed in a future PR.

@charliermarsh charliermarsh marked this pull request as ready for review May 29, 2024 17:08
@charliermarsh charliermarsh added the preview Experimental behavior label May 29, 2024
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #3912 will degrade performances by 9.11%

Comparing charlie/ex-i (0b95208) with main (fb0dfef)

Summary

❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/ex-i Change
resolve_warm_jupyter 82.4 ms 90.7 ms -9.11%

@charliermarsh charliermarsh force-pushed the charlie/ex-i branch 2 times, most recently from 7433a95 to 525a21a Compare May 29, 2024 17:28
@charliermarsh charliermarsh enabled auto-merge (squash) May 29, 2024 19:08
@charliermarsh charliermarsh merged commit 1bd5d8b into main May 29, 2024
44 of 46 checks passed
@charliermarsh charliermarsh deleted the charlie/ex-i branch May 29, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant