Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore query errors during uv toolchain list #4382

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Ignore query errors during uv toolchain list #4382

merged 1 commit into from
Jun 18, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 18, 2024

Closes #4380

This is the same logic as should_stop_discovery but I changed the log level and duplicated it because I don't really want that method to be public. Maybe it should be though?

@zanieb zanieb added bug Something isn't working preview Experimental behavior labels Jun 18, 2024
@zanieb zanieb marked this pull request as ready for review June 18, 2024 14:16
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this code looks like it has enough details where it might be worth making it DRY, but I don't feel strongly.

@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024

Refactoring...

@zanieb zanieb enabled auto-merge (squash) June 18, 2024 14:44
@zanieb zanieb merged commit 58f53f0 into main Jun 18, 2024
47 checks passed
@zanieb zanieb deleted the zb/list-error branch June 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv toolchain list throws error and fails to display list because Python 2 is on the PATH
2 participants