Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support toolchain requests with platform-tag style Python implementations and version #4407

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Support toolchain requests with platform-tag style Python implementations and version #4407

merged 2 commits into from
Jun 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 18, 2024 •
edited
Loading

Closes #4399

@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Jun 18, 2024
@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024

cc @fynnsu

BurntSushi
BurntSushi approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think I would probably write some of this code differently, but I defer to you. :)

crates/uv-toolchain/src/discovery.rs Outdated Show resolved Hide resolved
crates/uv-toolchain/src/discovery.rs Outdated Show resolved Hide resolved
@zanieb zanieb enabled auto-merge (squash) June 19, 2024 15:59
@zanieb zanieb merged commit a68146d into main Jun 19, 2024
47 checks passed
@zanieb zanieb deleted the zb/request-platform-tag branch June 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

@konstin konstin Awaiting requested review from konstin

Assignees
No one assigned
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support interpreter requests with wheel platform compatibility tags
2 participants
@zanieb @BurntSushi