Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite loop for cyclic installs #4633

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Avoid infinite loop for cyclic installs #4633

merged 1 commit into from
Jun 28, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #4629.

Test Plan

Run uv sync with:

[project]
name = "foo"
version = "0.1.0"
requires-python = ">=3.9"
dependencies = ["poetry"]

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels Jun 28, 2024
name = "project"
version = "0.1.0"
requires-python = ">=3.12"
dependencies = ["testtools==2.3.0", "fixtures==3.0.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smallest case I could find (surfaced from an old Poetry issue and then digging through the versions that were relevant back in 2018)...

@charliermarsh charliermarsh enabled auto-merge (squash) June 28, 2024 20:01
@charliermarsh charliermarsh merged commit 164160d into main Jun 28, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/c branch June 28, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv add hangs with circular dependencies in the lock file.
2 participants