Make entrypoint writes atomic to avoid overwriting symlinks #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/atomic
branch
from
fbf8c1d
to
76c8529
Compare
konstin
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that if
pathis a symlink,File::create(path)?.write_all(content.as_ref())?will overwrite the target file. That means an entrypoint namedpythonwould actually overwrite the user's source Python executable, which is symlinked into the virtual environment.This PR replaces that code with our atomic write method.
Closes #5152.
Test Plan
I ran through the test plan
https://github.com/astral-sh/uv/issues/5152, but used an executable namedbarlinked tofoo.txtinstead...