Use +- install output for Python versions #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
charliermarsh
commented
Jul 19, 2024
| installation.key().green(), | ||
| )?; | ||
| } | ||
| } |
There was a problem hiding this comment.
This ended up feeling unnecessary now that we show the summary at the end.
charliermarsh
commented
Jul 19, 2024
| @@ -350,7 +350,7 @@ impl Ord for PythonInstallationKey { | |||
| fn cmp(&self, other: &Self) -> std::cmp::Ordering { | |||
| self.implementation | |||
| .cmp(&other.implementation) | |||
| .then_with(|| other.version().cmp(&self.version())) | |||
| .then_with(|| self.version().cmp(&other.version())) | |||
There was a problem hiding this comment.
I think this is inverted.
There was a problem hiding this comment.
Sorry I should've added a explanation here. This is intentional to ensure that Python installations are sorted in descending order by version. #5139
There was a problem hiding this comment.
Hah, I'll take a look.
|
Thank you! |
charliermarsh
added a commit
that referenced
this pull request
Jul 19, 2024
## Summary See: #5139 and #5201 (comment). ## Test Plan Verified that 3.12 was chosen above 3.8 in: - `cargo run -- python uninstall --all` - `cargo run -- python install 3.8 3.12` - `cargo run -- tool run -v httpx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4939. Uses a format that's closer to
uv pip install, with some special-casing for single Pythons.Test Plan
A few examples: