Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cleanup): remove gossipnet crate #334

Closed
Tracked by #325
joroshiba opened this issue Sep 6, 2023 · 0 comments · Fixed by #407
Closed
Tracked by #325

(cleanup): remove gossipnet crate #334

joroshiba opened this issue Sep 6, 2023 · 0 comments · Fixed by #407
Labels
conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate

Comments

@joroshiba
Copy link
Member

joroshiba commented Sep 6, 2023 •
edited by sync-by-unito bot
Loading

Based on discussion in #325, where we have opted for option 1.

Blocked by #332 and #333. Once we have removed usages of gossipnet we should remove the crate.
@joroshiba joroshiba mentioned this issue Sep 6, 2023
Closed
@SuperFluffy SuperFluffy mentioned this issue Sep 20, 2023
Merged
@noot noot mentioned this issue Sep 20, 2023
Closed
@sambukowski sambukowski added conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate labels Sep 20, 2023
SuperFluffy added a commit that referenced this issue Sep 20, 2023
@SuperFluffy
gossipnet: remove (#407)
c67fda3 
## Summary
Remove the gossipnet crate and mentions of it.

## Background
Patches #383,
#384 removed gossipnet from
sequencer-relayer and conductor. This patch removes the
`astria-gossipnet` crate altogether because it is no longer used.

This PR does not update the conductor spec but leaves it as a follow-up.

## Changes
- Remove `astria-gossipnet`, update README, github workflow, workspace
Cargo.toml to reflect that
- Remove `gossipnet` mentions from astria-conductor

## Testing
not applicable

## Related Issues

closes #334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gossipnet: remove astriaorg/astria
2 participants
@joroshiba @sambukowski