conductor: update Executor::execute_block() to accommodate execution_commit_level
#345
Labels
conductor
pertaining to the astria-conductor crate
Comments
This was referenced Sep 20, 2023
5 tasks
sambukowski
added a commit
that referenced
this issue
Oct 12, 2023
## Summary Add a setting that allows rollup user to configure the origin of blocks that get sent to the rollup. ## Background Currently Conductor sends all blocks from all sources (sequencer and DA). Rollup user may want to change this functionality and chose to only ingest blocks from DA and/or the sequencer. ## Changes - [x] Add `execution_commit_level` to `Config` - [x] Add `EXECUTION_COMMIT_LEVEL` env var to local.env.example - [x] Remove `ASTRIA_CONDUCTOR_DISABLE_FINALIZATION` as an env var to be replaced with `EXECUTION_COMMIT_LEVEL` - [x] Update Conductor initialization to use `execution_commit_level` ## Testing - [x] existing tests pass ## Related Issues replaces #342 because #455 got merged closes #250 closes #345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The PR that adds
execution_commit_levelsetting doesn't change the functionality of the Executor.Once the new api is added (#205 #207) and gossipnet is removed from the Conductor (#332), this issue is a reminder to update
Executor::execute_block()to allow theexecution_commit_levelsetting to do modify Executor's behavior.blocked by #205
blocked by #207
blocked by #332
blocked by #342
The text was updated successfully, but these errors were encountered: