metrics(relayer)!: make per submission gauges into histograms #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
sequencer-relayer
SuperFluffy
force-pushed
the
superfluffy/histogram-not-gauge
branch
from
2c02d26
to
e23bb9e
Compare
Fraser999
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes various *per_tx metrics gauges into histograms.
Background
Making the *per_tx metrics into histograms will allow summing over all Celestia submissions and will give a running total of bytes, blobs, and blocks submitted to Celestia.
Changes
astria_sequencer_relayer_blobs_per_celestia_txfromgaugetohistogramastria_sequencer_relayer_blocks_per_celestia_txfromgaugetohistogramastria_sequencer_relayer_total_blob_data_size_for_astria_blockastria_sequencer_relayer_bytes_per_celestia_txTesting
Metrics need to be tested by observing them.
Metrics
astria_sequencer_relayer_bytes_per_celestia_txBreaking Changelist