chore(core): remove ed25519_consensus from public API #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steezeburger
added a commit
that referenced
this pull request
Jul 29, 2024
* main: release: cut bridge withdrawer release (#1303) release: version cuts for dusk-9 (#1299) chore(core): remove ed25519_consensus from public API (#1277) chore: remove spurious entry in gitignore (#1276) chore(chart): Update EVM-Rollup Geth devTag (#1300) fix(proto)!: Change execution API to use primitive RollupId (#1291) refactor(core, proto)!: define bridge memos in proto (#1285) chore(sequencer-relayer)!: minimize resubmissions to Celestia (#1234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that ed25519_consensus is not part of the public
astria-coreAPI.Background
The definition
struct astria_core::crypto::Error(#[from] ed25519_consensus::Error)leaksed25519_consensus::Errorinto the public API ofastria-core. This patch removes the#[from]attribute and updates a few lines by explicit constructors,map_err(Error).Changes
From<ed25519_consensus::Error> for crypto::Errorimpl, removinged25519_consensusfromastria-core's public API.Breaking Changelist
This is a breaking change in
astria-corebut not in any of our services. Because we don't yet publishastria-core, this is not a breaking change at this moment but would be breaking in the future.Related Issues
Closes #1221