Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bytes and ics23 crates #1279

Merged
merged 2 commits into from
Jul 18, 2024
Merged

chore: update bytes and ics23 crates #1279

merged 2 commits into from
Jul 18, 2024

Conversation

Fraser999
Copy link
Contributor

@Fraser999 Fraser999 commented Jul 17, 2024

Summary

Updated the bytes and ics23 crates.

Background

The version of bytes we currently use has been yanked due to a bug. Running cargo audit exposed this as an allowed warning.

We also got a report of an issue with the ics23 crate and a recommendation to update to v0.11.3.

Changes

  • Ran cargo update -p bytes and cargo update -p ics23.

Testing

No additional tests required.

@Fraser999 Fraser999 requested a review from a team as a code owner July 17, 2024 16:19
@Fraser999 Fraser999 requested a review from noot July 17, 2024 16:19
@Fraser999 Fraser999 changed the title chore: update bytes crate chore: update bytes and ics23 crates Jul 17, 2024
@Fraser999 Fraser999 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 23e45be Jul 18, 2024
48 checks passed
@Fraser999 Fraser999 deleted the fraser/update-bytes branch July 18, 2024 09:55
steezeburger added a commit that referenced this pull request Jul 19, 2024
* main: (24 commits)
  chore: update `bytes` and `ics23` crates (#1279)
  fix(sequencer): improve and fix instrumentation (#1255)
  feature(charts): hermes chart fixes, bech32 updates, ibc bridge test (#1130)
  chore(cli): remove unused rollup cli code (#1275)
  chore(test): use a temporary file to not pollute the workspace (#1269)
  chore(sequencer): add mempool benchmarks (#1238)
  fix(bridge-withdrawer)!: fix nonce handling (#1215)
  feat(cli, bridge-withdrawer)!: share code between cli and service (#1270)
  feat(cli): add cmd to collect withdrawal events and submit as actions (#1261)
  fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266)
  fix(withdrawer): support withdrawer address that differs from bridge address   (#1262)
  (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260)
  fix(charts): add resources for sequencer/cometbft (#1254)
  chore(sequencer)!: add metrics (#1248)
  fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243)
  feat(core, proto)!: make bridge unlock memo string (#1244)
  fix(conductor): don't panic during panic (#1252)
  feat(core)!: lowerCamelCase for protobuf json mapping (#1250)
  refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190)
  fix: rollup archive node configurations (#1249)
  ...
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
## Summary
Updated the `bytes` and `ics23` crates.

## Background
The version of `bytes` we currently use has been yanked due to [a
bug](tokio-rs/bytes#718). Running `cargo audit`
exposed this as an allowed warning.

We also got a report of an issue with the `ics23` crate and a
recommendation to update to v0.11.3.

## Changes
- Ran `cargo update -p bytes` and `cargo update -p ics23`.

## Testing
No additional tests required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants