chore(ci): bump rust toolchain to 1.81 #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
SuperFluffy
force-pushed
the
ENG-819/bump-msrv-to-1.81
branch
2 times, most recently
from
8415675
to
9142701
Compare
github-actions
bot
added
conductor
SuperFluffy
force-pushed
the
ENG-819/bump-msrv-to-1.81
branch
4 times, most recently
from
c084b23
to
c751c24
Compare
SuperFluffy
force-pushed
the
ENG-819/bump-msrv-to-1.81
branch
from
cb99f5b
to
4852565
Compare
SuperFluffy
force-pushed
the
ENG-819/bump-msrv-to-1.81
branch
from
4852565
to
f32e820
Compare
Fraser999
reviewed
Sep 23, 2024
| @@ -13,6 +13,8 @@ on: | |||
| env: | |||
| REGISTRY: ghcr.io | |||
| FULL_REF: ${{ inputs.tag && format('refs/tags/{0}', inputs.tag) || github.ref }} | |||
| # This must match the entry in rustup-toolchain.toml at the repository root | |||
| RUSTUP_TOOLCHAIN: "1.81.0" | |||
There was a problem hiding this comment.
I guess we could name this RUST_TOOLCHAIN to be consistent with the filename?
Also, could we read the appropriate value from the rust-toolchain.toml file here rather than having to keep these in sync?
There was a problem hiding this comment.
RUSTUP_TOOLCHAIN is the actual env var that's read by rust: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file, so I'd like to keep that.
And I guess we could extract this, but I didn't want to move away from dtolnay/rust-toolchain (at least for now), and parsing toml files in workflows can only be done through obscure github actions, which I didn't feel comfortable introducing.
Followup?
Fraser999
approved these changes
Sep 23, 2024
joroshiba
approved these changes
Sep 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Summary We accidentally broke the reusable build script with a poorly formatted workflow file in #1523 this fixes it.
bharath-123
pushed a commit
that referenced
this pull request
Sep 26, 2024
## Summary Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0. ## Background Rust [1.81 was released](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html) and comes with a load of niceties that we would like to use. Among them of immediate interest are: 1. lint reasons (#1521) 2. fixes `clippy::blocks_in_conditions` lint triggering on proc macros like `tracing::instrument` (which #1368 needed to work around) 3. lazy lock and lazy cell (to replace once_cell) in 1.80 (#1520) 4. checked cfg names (also 1.80 which flags a few issues in our code and should be immediately available). Note that this is orthgonal to setting the MSRV in individual Astria crates. ## Changes - Updates all github workflows to use the `1.81.0` toolchain (except for rustfmt and dylint, which need nightlies, respectively). - Fix all new clippy warnings. - Upgraded to the most recent dylint to make it compile again - Upgrade the single containerfile to use `rust:1.81-bookwarm` as the base image ## Related Issues Closes #1522
bharath-123
pushed a commit
that referenced
this pull request
Sep 26, 2024
## Summary We accidentally broke the reusable build script with a poorly formatted workflow file in #1523 this fixes it.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
## Summary Implemented usage of `#[expect]` instead of `#[allow]` following bump to Rust 1.81 ## Background With the recent bump to Rust 1.81 (#1523), the usage of `#[expect]` is now stable. This is preferable because it warns in case the lint is unfulfilled, keeping us from having superfluous allow attributes. ## Changes - Changed `test.yml` to include `clippy::allow_attributes` and `clippy::allow_attributes_with_no_reason` lints - Updated all crates to use Rust 1.81.0 - Migrated all instances of `#[allow]` to `#[expect]`, with the exception of our generated modules. - Deleted all allow attributes which were no longer useful ## Testing Passing all tests ## Related Issues closes #1521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0.
Background
Rust 1.81 was released and comes with a load of niceties that we would like to use. Among them of immediate interest are:
clippy::blocks_in_conditionslint triggering on proc macros liketracing::instrument(which chore(sequencer): Add instrumentation #1368 needed to work around)Note that this is orthgonal to setting the MSRV in individual Astria crates.
Changes
1.81.0toolchain (except for rustfmt and dylint, which need nightlies, respectively).rust:1.81-bookwarmas the base imageRelated Issues
Closes #1522